-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop branch - ccache added build dependency for the build-with-qmake.sh script not explicitely documented #211
Comments
Fixup for commit 03837e6 "Issue robert7#171: switch docker build to Ubuntu focal and using system browser for OAuth" Sync the README to point to the new ubuntu focal Dockerfile. The old xenial one is no more. Closes robert7#211.
I added ccache to speed up the build process. It was intentional, not accidental. |
@d1vanov so I thought. Thanks for the feedback. Still, for completeness. Did you intend to intentionally speed up the docker builds or as you did speed up all |
The latter, for all builds. Ccache is quite useful especially in situations when qmake actually changes the generated makefile somehow which triggers full rebuild of the project. With ccache this rebuild would be much faster than without it. |
Fixup for commit 03837e6 "Issue robert7#171: switch docker build to Ubuntu focal and using system browser for OAuth" Sync the README to point to the new ubuntu focal Dockerfile. The old xenial one is no more. Closes robert7#211.
Commit 03837e6 "Issue #171: switch docker build to Ubuntu focal and using system browser for OAuth" introduced a new build dependency on ccache for the
./development/build-with-qmake.sh
script.Develop branch.
Was the added
QMAKE_CXX="ccache g++"
done on purpose or was a local build optimization that slept through?Could it be related to the docker build process per the description?
The ccache added dependency might not be a leftover per it was added to the docker build dependencies.
Still, the README in the develop branch still point to the old docker file since then removed to tell the dependencies, that is https://github.com/robert7/nixnote2/blob/develop/development/docker/Dockerfile.ubuntu_xenial instead of the new https://github.com/robert7/nixnote2/blob/develop/development/docker/Dockerfile.ubuntu_focal (which has the ccache build dependency listed).
The text was updated successfully, but these errors were encountered: