Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop branch - ccache added build dependency for the build-with-qmake.sh script not explicitely documented #211

Closed
prahal opened this issue Sep 26, 2023 · 4 comments

Comments

@prahal
Copy link

prahal commented Sep 26, 2023

Commit 03837e6 "Issue #171: switch docker build to Ubuntu focal and using system browser for OAuth" introduced a new build dependency on ccache for the ./development/build-with-qmake.sh script.

Develop branch.

Was the added QMAKE_CXX="ccache g++" done on purpose or was a local build optimization that slept through?

Could it be related to the docker build process per the description?

The ccache added dependency might not be a leftover per it was added to the docker build dependencies.
Still, the README in the develop branch still point to the old docker file since then removed to tell the dependencies, that is https://github.com/robert7/nixnote2/blob/develop/development/docker/Dockerfile.ubuntu_xenial instead of the new https://github.com/robert7/nixnote2/blob/develop/development/docker/Dockerfile.ubuntu_focal (which has the ccache build dependency listed).

@prahal prahal changed the title develop branch - was the ccache added build dependency foir the build-with-qmake.sh script purposedely added? develop branch - ccache added build dependency for the build-with-qmake.sh script not explicitely documented Sep 26, 2023
prahal added a commit to prahal/nixnote2 that referenced this issue Sep 26, 2023
Fixup for commit 03837e6 "Issue robert7#171: switch docker build to Ubuntu focal and using system browser for OAuth"

Sync the README to point to the new ubuntu focal Dockerfile. The old xenial one is no more.

Closes robert7#211.
@d1vanov
Copy link

d1vanov commented Sep 26, 2023

I added ccache to speed up the build process. It was intentional, not accidental.

@prahal
Copy link
Author

prahal commented Sep 26, 2023

@d1vanov so I thought. Thanks for the feedback.
So my fixup of the README will do to fix this issue (i.e. the README tells us to read the Dockerfile to find the build dependencies, but currently in the develop branch the README points to nowhere as the Dockerfile it points to has been removed). As the new Dockerfile I made the README points in my Pull request #212 has ccache in it, that will do.

Still, for completeness. Did you intend to intentionally speed up the docker builds or as you did speed up all ./development/build-with-qmake.sh builds?

@d1vanov
Copy link

d1vanov commented Sep 26, 2023

The latter, for all builds. Ccache is quite useful especially in situations when qmake actually changes the generated makefile somehow which triggers full rebuild of the project. With ccache this rebuild would be much faster than without it.

@prahal
Copy link
Author

prahal commented Oct 3, 2023

#212 has been merged in the develop branch in e7ed12b, closing

@prahal prahal closed this as completed Oct 3, 2023
charlescanato pushed a commit to charlescanato/nixnote2 that referenced this issue Nov 21, 2023
Fixup for commit 03837e6 "Issue robert7#171: switch docker build to Ubuntu focal and using system browser for OAuth"

Sync the README to point to the new ubuntu focal Dockerfile. The old xenial one is no more.

Closes robert7#211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants