Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx_1517 add mapping connector #5

Merged
merged 9 commits into from
Feb 7, 2024
Merged

feature/mx_1517 add mapping connector #5

merged 9 commits into from
Feb 7, 2024

Conversation

erichesse
Copy link
Contributor

PR Context

Added

  • add mapping connector

Changes

Deprecated

Removed

Fixed

Security

@erichesse erichesse self-assigned this Feb 6, 2024
@erichesse erichesse changed the title add mapping connector feature/mx_1517 add mapping connector Feb 6, 2024
cutoffthetop
cutoffthetop requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 i have just one naming-things-issue

mex/mapping/connector.py Outdated Show resolved Hide resolved
assets/mappings/__final__/test_mapping/access-platform.yaml Outdated Show resolved Hide resolved
cutoffthetop
cutoffthetop requested changes Feb 7, 2024
View reviewed changes
.pre-commit-config.yaml.rej Outdated Show resolved Hide resolved
pyproject.toml.rej Outdated Show resolved Hide resolved
@erichesse erichesse merged commit ca8b909 into main Feb 7, 2024
9 checks passed
@erichesse erichesse deleted the feature/mx_1517_build_a_mapping_connector branch February 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@erichesse erichesse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichesse @cutoffthetop