Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/reflex app maintenance #234

Merged
merged 4 commits into from
Feb 7, 2025
Merged

feature/reflex app maintenance #234

merged 4 commits into from
Feb 7, 2025

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Feb 4, 2025 •
edited
Loading

PR Context

Added

  • update mex-common to version 0.49.3
  • BREAKING: you must start the local dev mode simply with pdm run drop (no 2nd run)
  • move custom backend exception handler to its own module
  • move custom api code to its own package mex.drop.api
  • align general layout functions (page, logo, navbar, etc) with mex-editor
  • align login component and navbar state handling with mex-editor
  • update styling with more idiomatic variable syntax and responsive scaling

Fixed

  • decorate state handlers with @rx.event to satisfy new reflex versions

rababerladuseladim
rababerladuseladim requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix tests

mex/mex.py Outdated Show resolved Hide resolved
@cutoffthetop cutoffthetop marked this pull request as draft February 4, 2025 13:24
@cutoffthetop
Copy link
Contributor Author

Pls fix tests

yep sorry, should've created a draft first. this isn't review-ready yet

@cutoffthetop cutoffthetop marked this pull request as ready for review February 4, 2025 15:03
rababerladuseladim
rababerladuseladim approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and pretty, thank you for the beauty! Only one comment, feel free to ignore.

tests/conftest.py Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit 5684409 into main Feb 7, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/repo-maint-20250204 branch February 7, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim