-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/mx-1632 structured file support #134
Conversation
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Co-authored-by: Nicolas Drebenstedt <[email protected]> Signed-off-by: ZehraVictoria <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
…robert-koch-institut/mex-drop into feature/mx-1617-add-file-upload
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
d03fe2a
to
31b3069
Compare
…hub.com/robert-koch-institut/mex-drop into feature/mx-1632-structured-file-support Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Few little things to fix.
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
Signed-off-by: Zehra Ciftci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I do have a few remarks.
First and foremost: One test fails locally: tests/test_main.py::test_index[firefox]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, almost done.
A few remarks:
- could you move the helper functions and variables to a dedicated module, e.g.
files_io.py
? - I struggled to understand which conversations where fully addressed. To make this easier, we usually work with conversations as follows:
- the reviewer closes conversations when she/he deems the issues fully addressed
- the developer adds a comment with the hash of the commit that includes the fix (this facilitates finding of the fix and spotting which conversations you already replied to)
One major remark:
I tried to upload a csv file and get the following error:
{
"detail": "Content doesn't match extension: application/vnd.ms-excel != Joplin-Setup-3.0.15.csv"
}
I'm not sure who sets that content type, I assume it's the browser. Certainly not me.
And one more: could you document the allowed file types in swagger as well? That makes using the API easier. |
It seems csv files edited in MS Excel are recognized as
Also added 5c69fc5. I didn't find anything useful on how to limit the file types in the file selecter popup though
fixed in 35bffdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biu-ti-ful! And almost there, just some tiny nitpicking left.
Signed-off-by: ZehraVictoria <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh boi, just one tiny thing left.
requested changes applied
PR Context
So far mex drop only allows JSON file upload.
This establishes compatibility with most common structured file formats.
Added