Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trashed shedule not showing #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abhishekpaul
Copy link

  • Custom command not showing while edit
  • Deleted schudule not able to edit and details page as well
  • Form validation not working properly

@what-the-diff
Copy link

what-the-diff bot commented Mar 27, 2023

PR Summary

  • Enhanced custom input field Added a value attribute to the command_custom input field
  • Support for editing deleted schedules Enabled editing of deleted schedules by binding the Schedule model route with the trashed() method
  • Improved data validation in controller Updated create and update methods to use validated data instead of all request data, preventing mass assignment
  • Additional validation rules Introduced validation rules for previously overlooked boolean fields

@thyseus thyseus requested a review from robersonfaria March 27, 2023 09:18
Copy link
Owner

@robersonfaria robersonfaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

abhishekpaul

This comment was marked as off-topic.

@robersonfaria
Copy link
Owner

hello @abhishekpaul

I believe we have a breaking change, packages are breaking with the PHP version, I believe I will need to create an end tag and generate a new tag discontinuing support for older PHP versions.

I'm a little busy today, but I'll try to find time in the next few days to resolve this issue and then merge your pull request.

Thanks for the contribution, I'll keep you posted.

@abhishekpaul
Copy link
Author

Hi @robersonfaria any update or timeline on this ?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants