Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Basildon Council #838

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

eugeneniemand
Copy link
Contributor

Adding Basildon Council (Essex)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (27f252c) to head (425aeda).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files           4        4           
  Lines         253      253           
=======================================
  Hits          246      246           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad
Copy link
Owner

robbrad commented Oct 4, 2024

Looks good @eugeneniemand

Check https://github.com/robbrad/UKBinCollectionData/actions/runs/11182453170/job/31090642306#step:12:1

The date format needs to match the schema. Reason for this is consistency with the custom component

Thanks
Rob

@eugeneniemand
Copy link
Contributor Author

@robbrad Apologies mate, I dont know python that well, and knocked this together in about 20 minutes never even looking at the date format as I'm so used to using the ISO 8601 format that is didnt occur to me that it needs to be changed. Should all be fixed now

@eugeneniemand
Copy link
Contributor Author

@robbrad not sure what to do about commit lint error, I see many other failures so not sure if its required

@robbrad robbrad merged commit 05ffb81 into robbrad:master Oct 7, 2024
10 of 11 checks passed
@eugeneniemand eugeneniemand deleted the basildon-council branch October 8, 2024 22:01
@eugeneniemand
Copy link
Contributor Author

@robbrad just curious if this has gone into release 0.92.0 as I cant see it when adding the integration in HA? Did I miss something to enable it?

@robbrad
Copy link
Owner

robbrad commented Oct 8, 2024

Yeh unfortunately you need to prefix all commit message with either feat: or fix:

Otherwise the pipeline won't pick up the version release. It's mentioned in the contributing.md

Unfortunately it's quite hard to rework multiple commits so I tend to merge peoples work if it's passing the tests which yours was.

Options are wait until someone else does the next commit or make a small commit and I'll approve

@robbrad
Copy link
Owner

robbrad commented Oct 8, 2024

@eugeneniemand fixing it now

@robbrad
Copy link
Owner

robbrad commented Oct 8, 2024

Ok v93 should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants