-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Basildon Council #838
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 4 4
Lines 253 253
=======================================
Hits 246 246
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Looks good @eugeneniemand The date format needs to match the schema. Reason for this is consistency with the custom component Thanks |
@robbrad Apologies mate, I dont know python that well, and knocked this together in about 20 minutes never even looking at the date format as I'm so used to using the ISO 8601 format that is didnt occur to me that it needs to be changed. Should all be fixed now |
@robbrad not sure what to do about commit lint error, I see many other failures so not sure if its required |
@robbrad just curious if this has gone into release 0.92.0 as I cant see it when adding the integration in HA? Did I miss something to enable it? |
Yeh unfortunately you need to prefix all commit message with either feat: or fix: Otherwise the pipeline won't pick up the version release. It's mentioned in the contributing.md Unfortunately it's quite hard to rework multiple commits so I tend to merge peoples work if it's passing the tests which yours was. Options are wait until someone else does the next commit or make a small commit and I'll approve |
@eugeneniemand fixing it now |
Ok v93 should be good |
Adding Basildon Council (Essex)