Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gloucester city council driver #807

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

simoncozens
Copy link
Contributor

Fixes #565.

$ PYTHONPATH=. python3 uk_bin_collection/uk_bin_collection/collect_data.py GloucesterCityCouncil https://gloucester-self.achieveservice.com/en/service/Bins___Check_your_bin_day -p "GL2 5EX" -n 73 -u 10007315012
{
    "bins": [
        {
            "type": "Household waste (black bin)",
            "collectionDate": "13/09/2024"
        },
        {
            "type": "Household recycling (green box, brown food bin and blue sack)",
            "collectionDate": "13/09/2024"
        }
    ]
}

simoncozens added a commit to simoncozens/UKBinCollectionData that referenced this pull request Sep 9, 2024
simoncozens added a commit to simoncozens/UKBinCollectionData that referenced this pull request Sep 9, 2024
@simoncozens simoncozens force-pushed the add-gloucester-cc branch 2 times, most recently from 26cbf83 to 5c41af3 Compare September 9, 2024 14:17
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (0f6c690) to head (741db63).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #807   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files           4        4           
  Lines         253      253           
=======================================
  Hits          246      246           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad
Copy link
Owner

robbrad commented Sep 9, 2024

@simoncozens : https://github.com/robbrad/UKBinCollectionData/actions/runs/10775106025/job/29878905553

Looks like it's failing for our test address in the tests/input.json file

@simoncozens
Copy link
Contributor Author

Gah. I've been testing with local browser, not Selenium. It will probably take me a while to get around to setting up docker and all the other gubbins. If you want to take over the PR, please feel free.

@robbrad
Copy link
Owner

robbrad commented Sep 9, 2024

We have a dev container that includes selenium as a setup etc https://github.com/robbrad/UKBinCollectionData/tree/master/.devcontainer

You can use VSCode with this

@robbrad
Copy link
Owner

robbrad commented Sep 9, 2024

@simoncozens Just tested this on the devcontainer and it worked fine - ill merge now

@robbrad robbrad merged commit 1fd43f7 into robbrad:master Sep 9, 2024
11 checks passed
@gjpgjp
Copy link

gjpgjp commented Sep 9, 2024

Does this need a selenium server to work, there is no option in the configuration for Gloucester City Council to specify a server URL

@robbrad
Copy link
Owner

robbrad commented Sep 10, 2024

Does this need a selenium server to work, there is no option in the configuration for Gloucester City Council to specify a server URL

Ah that needs adding to the input.json in the code

@simoncozens are you able to add that line? If not I can.

Just have a look at another council and copy it exactly the same. That's how the custom component knows it's selenium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gloucester City Council
3 participants