-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gloucester city council driver #807
Conversation
9534664
to
4473be4
Compare
26cbf83
to
5c41af3
Compare
5c41af3
to
741db63
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 4 4
Lines 253 253
=======================================
Hits 246 246
Misses 7 7 ☔ View full report in Codecov by Sentry. |
@simoncozens : https://github.com/robbrad/UKBinCollectionData/actions/runs/10775106025/job/29878905553 Looks like it's failing for our test address in the tests/input.json file |
Gah. I've been testing with local browser, not Selenium. It will probably take me a while to get around to setting up docker and all the other gubbins. If you want to take over the PR, please feel free. |
We have a dev container that includes selenium as a setup etc https://github.com/robbrad/UKBinCollectionData/tree/master/.devcontainer You can use VSCode with this |
@simoncozens Just tested this on the devcontainer and it worked fine - ill merge now |
Does this need a selenium server to work, there is no option in the configuration for Gloucester City Council to specify a server URL |
Ah that needs adding to the input.json in the code @simoncozens are you able to add that line? If not I can. Just have a look at another council and copy it exactly the same. That's how the custom component knows it's selenium |
Fixes #565.