Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix module name in BirminghamCityCouncil.py #798

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix module name in BirminghamCityCouncil.py #798

merged 1 commit into from
Sep 3, 2024

Conversation

aptalca
Copy link
Contributor

@aptalca aptalca commented Sep 3, 2024

Incorrect path leads to import error:

Traceback (most recent call last):
  File "/lsiopy/lib/python3.12/site-packages/uk_bin_collection/uk_bin_collection/collect_data.py", line 134, in <module>
    run()
  File "/lsiopy/lib/python3.12/site-packages/uk_bin_collection/uk_bin_collection/collect_data.py", line 130, in run
    print(app.run())
          ^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/uk_bin_collection/uk_bin_collection/collect_data.py", line 100, in run
    council_module = import_council_module(self.parsed_args.module)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/uk_bin_collection/uk_bin_collection/collect_data.py", line 19, in import_council_module
    return importlib.import_module(module_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/lsiopy/lib/python3.12/site-packages/uk_bin_collection/uk_bin_collection/councils/BirminghamCityCouncil.py", line 8, in <module>
    from uk_bin_collection.common import *
ModuleNotFoundError: No module named 'uk_bin_collection.common'

@robbrad robbrad merged commit f33767f into robbrad:master Sep 3, 2024
7 of 8 checks passed
@aptalca aptalca deleted the patch-1 branch September 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants