Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-work North Tyneside Council module for 2024 #784

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

@psimonkey psimonkey mentioned this pull request Aug 10, 2024
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (f623bf0) to head (eec2dc4).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   87.98%   87.98%           
=======================================
  Files           3        3           
  Lines         208      208           
=======================================
  Hits          183      183           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psimonkey psimonkey changed the title Re-work North Tyneside Council module for 2024. fix: Re-work North Tyneside Council module for 2024 Aug 11, 2024
@psimonkey psimonkey closed this Aug 26, 2024
@psimonkey psimonkey reopened this Aug 26, 2024
@robbrad
Copy link
Owner

robbrad commented Aug 26, 2024

Hey @psimonkey looking at the test run there are some issues to fix on this.

Thanks
Rob

@psimonkey
Copy link
Contributor Author

Hi @robbrad - sorry, I didn't mean to close and re-open it like that. I was just trying to figure out how to fix the lint error on the commit messages. I'll look at the other build errors and get those fixed. Cheers.

@robbrad robbrad merged commit 80f3e03 into robbrad:master Aug 27, 2024
9 of 10 checks passed
@psimonkey
Copy link
Contributor Author

Hi @robbrad. Cheers for merging - I've confirmed that's working on my server after updating via HACS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants