Custom component selenium fix #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbrad
approved these changes
Nov 3, 2023
|
@OliverCullimore : sorry I created some merge conflicts by merging your other pr first |
…limore/UKBinCollectionData into custom-component-selenium-fix
robbrad
approved these changes
Nov 3, 2023
|
Looking at the Allure report we have a few issues urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='selenium', port=4444): Max retries exceeded with url: /session (Caused by NameResolutionError("<urllib3.connection.HTTPConnection object at 0x7f3df92d2350>: Failed to resolve 'selenium' ([Errno -3] Temporary failure in name resolution)")) |
|
Can confirm this does work in home assistant, at least -- for North Norfolk District council. For whatever reason the component doesn't seem to pickup entities for my council (EastSuffolk) despite the selenium bit definitely working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #381
@robbrad It looks like GitHub actions support services to allow us to run a Selenium chrome container to use in our remote web driver tests, I'm hoping that just works and doesn't break the behave tests if you can give it a once over in particular