Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace individual council schema's with a single common one #408

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

OliverCullimore
Copy link
Collaborator

@OliverCullimore OliverCullimore commented Oct 31, 2023

Closes #406

Using regex for the date to match our format with slashes

Type is just allowed to be any string which I think should be fine

Utilising "minItems" set to 1 to require at least one bins array entry for the JSON to be considered valid, so the test will fail if a scraper returns no bins now so we can monitor that in the allure reports

@robbrad
Copy link
Owner

robbrad commented Oct 31, 2023

Let's goooooooo

@robbrad robbrad merged commit 508410f into robbrad:master Oct 31, 2023
6 checks passed
@OliverCullimore OliverCullimore deleted the 406-replace-schema-files branch November 3, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace schema files
2 participants