Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update poetry.lock to allow any urllib3 version #369

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

OliverCullimore
Copy link
Collaborator

Potential fix for Home Assistant conflicting dependencies error ref #365 & #347

@OliverCullimore OliverCullimore added bug Something isn't working dependencies Pull requests that update a dependency file home assistant custom component Something related to the home assistant custom component labels Oct 15, 2023
@OliverCullimore OliverCullimore requested a review from dp247 October 15, 2023 20:48
@codecov-commenter
Copy link

Codecov Report

Merging #369 (c226f22) into master (1445263) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files           3        3           
  Lines         151      151           
=======================================
  Hits          126      126           
  Misses         25       25           

@OliverCullimore
Copy link
Collaborator Author

@dp247 was there any particular reason we're requiring version 2.0.6 of urllib3?

@dp247
Copy link
Collaborator

dp247 commented Oct 16, 2023

@dp247 was there any particular reason we're requiring version 2.0.6 of urllib3?

Not specifically - I needed a version of urllib3 for some HTTPContext code, but I don't think it specifically has to be 2.0.6 if its incompatible. I just told poetry to install latest haha.

@OliverCullimore
Copy link
Collaborator Author

@dp247 was there any particular reason we're requiring version 2.0.6 of urllib3?

Not specifically - I needed a version of urllib3 for some HTTPContext code, but I don't think it specifically has to be 2.0.6 if its incompatible. I just told poetry to install latest haha.

Thanks for confirming, hopefully this PR will fix the custom component without causing any other issues then

@OliverCullimore OliverCullimore merged commit 25e3e9b into robbrad:master Oct 16, 2023
@OliverCullimore OliverCullimore deleted the dependencies-fix branch October 18, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file home assistant custom component Something related to the home assistant custom component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants