December 2024 fixes #1088
December 2024 fixes #1088
Conversation
|
Gonna fix some councils just like the good old days @robbrad I appreciate you're very busy this time of year, but I noticed the Allure report has a 404 too (though I'm not raising it as an issue as its not directly plugin related lol). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 71.93% 71.93%
=======================================
Files 9 9
Lines 1037 1037
=======================================
Hits 746 746
Misses 291 291 ☔ View full report in Codecov by Sentry. |
Been trying to fix it today but no luck yet. I might separate out the publish to a different job so I can rerun it. At the moment it's an hour to find out if my changes worked 🥹 |
fix: robbrad#1080 (cherry picked from commit 6f580b3)
fix: robbrad#1076 (cherry picked from commit 1eab20c)
(cherry picked from commit 8e70e6a)
|
Hope you don't mind @m26dvd, I cherry-picked some of your fixes to go in here 😄 |
No problem! I’ve not had time recently to do any more and it makes sense to batch release them rather than raise a PR for one fix! |
|
@dp247 I’ve also got a new scraper for 1078 if you fancy including it here too! |
Sure thing, I'll pick it after work 😊 |
fix: robbrad#1078 (cherry picked from commit 89d9366)
…orwich City Council
…nual mapping for Rugby Borough Council
|
@dp247 : are these two failures ok ? https://github.com/robbrad/UKBinCollectionData/actions/runs/12403956484/job/34628376787?pr=1088#step:7:567 If you are happy I will approve |
I'll take a look at them, though they don't seem to be breaking anything other than tests. Gonna stick another couple of issues in here too |
|
Think I've cut the error log down as much as I can, so ready for review :D |
|
When will this be approved and megred in to the master branch? |
We don't specify timelines since we're all volunteers, but it'll be merged after the code changes have been reviewed |
No problem, apologies i am just waiting for the kirklees changes |
Bug fixes
Closes Unexpected Error #1063
Closes MertonCouncil: Unexpected error: No connection adapters were found for 'python collect_data.py MertonCouncil #1072
Closes Missing ‘type’ or ‘collectiondate’ error in logs #1073
Closes Error reported after update to 0.122 #1076
Closes Swale Updated URL #1080
Closes Integration no longer works/sets up since recent update #1084
Closes Food Waste Bin Date Incorrect & request to add bin colours (if possible) #1087
Closes Bromley Borough Council dates are shifted by one year #1089
Closes Walsall Council No Longer Working #1101
Add missing backticks to README.md
Test fixes
Additions