Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ‘type’ or ‘collectiondate’ error in logs #1073

Open
4 tasks done
nickfennell opened this issue Dec 7, 2024 · 6 comments · May be fixed by #1088
Open
4 tasks done

Missing ‘type’ or ‘collectiondate’ error in logs #1073

nickfennell opened this issue Dec 7, 2024 · 6 comments · May be fixed by #1088
Assignees
Labels
bug Something isn't working

Comments

@nickfennell
Copy link

Name of Council

Rugby Borough Council

Issue Information

Error returned is below.

`This error originated from a custom integration.

Logger: custom_components.uk_bin_collection
Source: custom_components/uk_bin_collection/init.py:282
integration: UK Bin Collection Data (documentation, issues)
First occurred: 01:19:27 (12 occurrences)
Last logged: 01:33:47

[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '12/12/2024'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '19/12/2024'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '28/12/2024'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '02/01/2025'}
`

Verification

  • I searched for similar issues at https://github.com/robbrad/UKBinCollectionData/issues?q=is:issue and found no duplicates
  • I have checked my address/postcode/UPRN works on the council's website
  • I have provided a detailed explanation of the issue as well as steps to replicate the issue
  • I understand that this project is run by volunteer contributors therefore completion of this issue cannot be guaranteed
@nickfennell nickfennell added the bug Something isn't working label Dec 7, 2024
@m26dvd
Copy link
Contributor

m26dvd commented Dec 12, 2024

@nickfennell Is this still a problem? Bin types return okay for me.

If you are still having issues, can you provide an example UPRN/Postcode for testing purposes please?

@dp247
Copy link
Collaborator

dp247 commented Dec 18, 2024

Yeah, they're fine for me too. If you don't want to put your info here, you can find my email on my Github profile.

@nickfennell
Copy link
Author

Hi.

Apologies for slow reply. Updated the integration to 0.123.1 today.

Error shown in log file is as below:


This error originated from a custom integration.

Logger: custom_components.uk_bin_collection
Source: custom_components/uk_bin_collection/__init__.py:282
integration: UK Bin Collection Data (documentation, issues)
First occurred: 23:12:38 (4 occurrences)
Last logged: 23:12:38

[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '19/12/2024'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '28/12/2024'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '02/01/2025'}
[UKBinCollection] Missing 'type' or 'collectionDate' in bin data: {'type': None, 'collectionDate': '09/01/2025'}

Collection URL: https://www.rugby.gov.uk/check-your-next-bin-day
URN is: 10094755105
Postcode is: CV23 1FH

Thanks!

@dp247 dp247 self-assigned this Dec 19, 2024
dp247 added a commit to dp247/UKBinCollectionData that referenced this issue Dec 19, 2024
@dp247 dp247 linked a pull request Dec 19, 2024 that will close this issue
@dp247
Copy link
Collaborator

dp247 commented Dec 19, 2024

When I originally wrote this parser, I decided to map bins to colours. The issue was that none of the bin mappings could be found for the provided type, so it was throwing nulls. I've changed it to just pull the bin type and make it pretty now.

@nickfennell
Copy link
Author

Understood.

Will you be pushing a commit soon?

Thank you for investigating.

@dp247
Copy link
Collaborator

dp247 commented Dec 19, 2024

Yeah, it's fixed in #1088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants