fix: move logging config to collect_data script

uk_bin_collection/uk_bin_collection/collect_data.py

@@ -2,6 +2,10 @@
 import importlib
 import os
 import sys
+import logging
+from uk_bin_collection.uk_bin_collection.get_bin_data import setup_logging, LOGGING_CONFIG
+
+_LOGGER = logging.getLogger(__name__)
 
 # We use this method to dynamically import the council processor
 SRC_PATH = os.path.join("councils")
@@ -91,6 +95,8 @@ def run(self):
 if __name__ == "__main__":
     import sys
 
+    _LOGGER = setup_logging(LOGGING_CONFIG, None)
+
     app = UKBinCollectionApp()
     app.set_args(sys.argv[1:])
     data = app.run()

uk_bin_collection/uk_bin_collection/get_bin_data.py

@@ -12,6 +12,8 @@
 
 from uk_bin_collection.uk_bin_collection.common import update_input_json
 
+_LOGGER = logging.getLogger(__name__)
+
 LOGGING_CONFIG = dict(
     version=1,
     formatters={"f": {"format": "%(asctime)s %(name)-12s %(levelname)-8s %(message)s"}},
@@ -30,10 +32,6 @@ def setup_logging(logging_config, logger_name):
     except Exception as exp:
         raise exp
 
-
-LOGGER = setup_logging(LOGGING_CONFIG, None)
-
-
 # import the wonderful Beautiful Soup and the URL grabber
 
 
@@ -99,16 +97,16 @@ def get_data(cls, url) -> str:
             full_page = requests.get(url, headers, verify=False)
             return full_page
         except requests.exceptions.HTTPError as errh:
-            LOGGER.error(f"Http Error: {errh}")
+            _LOGGER.error(f"Http Error: {errh}")
             raise
         except requests.exceptions.ConnectionError as errc:
-            LOGGER.error(f"Error Connecting: {errc}")
+            _LOGGER.error(f"Error Connecting: {errc}")
             raise
         except requests.exceptions.Timeout as errt:
-            LOGGER.error(f"Timeout Error: {errt}")
+            _LOGGER.error(f"Timeout Error: {errt}")
             raise
         except requests.exceptions.RequestException as err:
-            LOGGER.error(f"Oops: Something Else {err}")
+            _LOGGER.error(f"Oops: Something Else {err}")
             raise
 
     @abstractmethod