Merge pull request #506 from skelt0/feat-gedling-borough-council

robbrad · Dec 27, 2023 · 4aa64c4 · 4aa64c4
2 parents a40118d + e1d3f76
commit 4aa64c4
Show file tree

Hide file tree

Showing 3 changed files with 232 additions and 2 deletions.
diff --git a/uk_bin_collection/tests/features/validate_council_outputs.feature b/uk_bin_collection/tests/features/validate_council_outputs.feature
@@ -47,6 +47,7 @@ Feature: Test each council output matches expected results
             | FenlandDistrictCouncil | None | None |
             | ForestOfDeanDistrictCouncil | http://selenium:4444 | local |
             | GatesheadCouncil | http://selenium:4444 | local |
+            | GedlingBoroughCouncil | None | None |
             | GlasgowCityCouncil | None | None |
             | GuildfordCouncil | None | None |
             | HaltonBoroughCouncil | http://selenium:4444 | local |

diff --git a/uk_bin_collection/tests/input.json b/uk_bin_collection/tests/input.json
@@ -223,7 +223,7 @@
     },
     "EastRidingCouncil": {
         "postcode": "HU17 8LG",
-        "house_number":"14 THE LEASES BEVERLEY HU17 8LG",
+        "house_number": "14 THE LEASES BEVERLEY HU17 8LG",
         "skip_get_url": true,
         "web_driver": "http://selenium:4444",
         "url": "https://wasterecyclingapi.eastriding.gov.uk",
@@ -281,6 +281,13 @@
         "wiki_name": "Gateshead Council",
         "wiki_note": "Pass the house name/number in the house number parameter, wrapped in double quotes"
     },
+    "GedlingBoroughCouncil": {
+        "house_number": "Valeside Gardens",
+        "skip_get_url": true,
+        "url": "https://www.gedling.gov.uk/",
+        "wiki_name": "Gedling Borough Council",
+        "wiki_note": "Pass the street name into the -n parameter. Use [this](https://apps.gedling.gov.uk/refuse/search.aspx) to help work out a street search that is unique. Known issues: 1) If multiple streets returned, it will pick the first and these may have different bin schedules. 2) This data is hand entered as council only provide non-parseable non-accessible PDFs - Please double check for any issues. 2b) Data is only included until end of Nov 2024 (refuse) and March 2024 (Garden). Data will need to be updated by hand after these dates."
+    },
     "GlasgowCityCouncil": {
         "url": "https://www.glasgow.gov.uk/forms/refuseandrecyclingcalendar/PrintCalendar.aspx?UPRN=906700034497",
         "wiki_command_url_override": "https://www.glasgow.gov.uk/forms/refuseandrecyclingcalendar/PrintCalendar.aspx?UPRN=XXXXXXXX",
@@ -830,4 +837,4 @@
         "url": "https://waste-api.york.gov.uk/api/Collections/GetBinCollectionDataForUprn/",
         "wiki_name": "York Council"
     }
-}
+}