-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for sending UDP multicast on IPv6 #239
Conversation
@Umberto73 Can you rebase this off the latest master and squash your commits? Thank you! |
Chris, could you be please be more specific on what you want me to do (and why)?
|
@Umberto73 basically he wants you to resolve conflicts (with latest head) and squash all commits so it would look like 1 |
Conflicts: Source/GCD/GCDAsyncUdpSocket.h
I've resolved the conflicts and committed them. Please verify.
|
This pull request has been marked as stale, it will be closed automatically if there is no further activity. |
@Umberto73 looks like this never made it into the repo. I'm having this problem, so it would be great to see it resolved! |
@dsmurfin Thanks for bringing this back up! Will take a look. |
Thanks Chris. I see GitHub actions has closed it again! |
Bad bot! |
This pull request has been marked as stale, it will be closed automatically if there is no further activity. |
Hi @chrisballinger it appears GitHub actions has closed this again! This definitely needs to be resolved as it's a bit of a flaw, but I don't have the time at present to put in a pull request myself. |
Merged via #746 |
This fix adds an API interface to set the network interface on which the multicast datagrams will be sent on. It is needed when sending UDP multicast on IPv6.
This fix was actually suggested by Arno as mentioned in:
https://groups.google.com/forum/#!topic/cocoaasyncsocket/Z9lqXGpR-kU
Huub