Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sending UDP multicast on IPv6 #239

Closed
wants to merge 4 commits into from

Conversation

huubeikens
Copy link

This fix adds an API interface to set the network interface on which the multicast datagrams will be sent on. It is needed when sending UDP multicast on IPv6.

This fix was actually suggested by Arno as mentioned in:
https://groups.google.com/forum/#!topic/cocoaasyncsocket/Z9lqXGpR-kU

Huub

@chrisballinger
Copy link
Collaborator

@Umberto73 Can you rebase this off the latest master and squash your commits? Thank you!

@huubeikens
Copy link
Author

Chris, could you be please be more specific on what you want me to do (and why)?

Op 25 aug. 2015, om 22:12 heeft Chris Ballinger [email protected] het volgende geschreven:

@Umberto73 https://github.com/Umberto73 Can you rebase this off the latest master and squash your commits? Thank you!


Reply to this email directly or view it on GitHub #239 (comment).

@RolandasRazma
Copy link

@Umberto73 basically he wants you to resolve conflicts (with latest head) and squash all commits so it would look like 1

Umberto73 added 2 commits September 8, 2015 19:48
@huubeikens
Copy link
Author

I've resolved the conflicts and committed them. Please verify.

Op 2 sep. 2015, om 17:34 heeft Rolandas Razma [email protected] het volgende geschreven:

@Umberto73 https://github.com/Umberto73 basically he wants you to resolve conflicts (with latest head) and squash all commits so it would look like 1


Reply to this email directly or view it on GitHub #239 (comment).

@github-actions
Copy link

This pull request has been marked as stale, it will be closed automatically if there is no further activity.

@dsmurfin
Copy link
Contributor

@Umberto73 looks like this never made it into the repo. I'm having this problem, so it would be great to see it resolved!

@chrisballinger
Copy link
Collaborator

@dsmurfin Thanks for bringing this back up! Will take a look.

@github-actions github-actions bot closed this Apr 19, 2020
@dsmurfin
Copy link
Contributor

@dsmurfin Thanks for bringing this back up! Will take a look.

Thanks Chris. I see GitHub actions has closed it again!

@chrisballinger
Copy link
Collaborator

Bad bot!

@github-actions
Copy link

This pull request has been marked as stale, it will be closed automatically if there is no further activity.

@dsmurfin
Copy link
Contributor

dsmurfin commented Sep 8, 2020

Hi @chrisballinger it appears GitHub actions has closed this again! This definitely needs to be resolved as it's a bit of a flaw, but I don't have the time at present to put in a pull request myself.

@chrisballinger
Copy link
Collaborator

Merged via #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants