Fix TR to continue if a DS regex is invalid.

Fixes Comcast#1587
rob05c · Jul 7, 2016 · 4208fa3 · 4208fa3
1 parent 6b178d0
commit 4208fa3
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/...re/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java b/...re/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
@@ -619,25 +619,23 @@ private static final Map<String, List<Record>> populateZoneMap(final Map<String,
 					continue;
 				}
 
-				final Name name = newName(fqdn);
-				final JSONObject ttl = ds.getTtls();
-
 				try {
-					zholder.add(new ARecord(name,
-						DClass.IN,
-						ZoneUtils.getLong(ttl, "A", 60),
-						c.getIp4()));
-				} catch (IllegalArgumentException e) {
-					LOGGER.warn(e + " : " + c.getIp4());
-				}
+					final Name name = newName(fqdn);
+					final JSONObject ttl = ds.getTtls();
 
-				final InetAddress ip6 = c.getIp6();
+					try {
+						zholder.add(new ARecord(name, DClass.IN, ZoneUtils.getLong(ttl, "A", 60), c.getIp4()));
+					} catch (IllegalArgumentException e) {
+						LOGGER.warn(e + " : " + c.getIp4());
+					}
+
+					final InetAddress ip6 = c.getIp6();
 
-				if (ip6 != null && ds != null && ds.isIp6RoutingEnabled()) {
-					zholder.add(new AAAARecord(name,
-							DClass.IN,
-							ZoneUtils.getLong(ttl, AAAA, 60),
-							ip6));
+					if (ip6 != null && ds != null && ds.isIp6RoutingEnabled()) {
+						zholder.add(new AAAARecord(name, DClass.IN, ZoneUtils.getLong(ttl, AAAA, 60), ip6));
+					}
+				} catch (org.xbill.DNS.TextParseException e) {
+					LOGGER.error("Caught fatal exception while generating zone data for " + fqdn  + "!", e);
 				}
 			}
 		}