Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

bug(sockets): socket erros during relocation #9

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

rustatian
Copy link
Member

Reason for This PR

Description of Changes

  • Return the correct relay pointer from the sync.Map.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added the B-bug Bug: bug, exception label Feb 14, 2022
@rustatian rustatian self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #9 (5ef135f) into master (5629950) will increase coverage by 1.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   78.10%   79.59%   +1.48%     
==========================================
  Files          20       21       +1     
  Lines        1754     1720      -34     
==========================================
- Hits         1370     1369       -1     
+ Misses        329      296      -33     
  Partials       55       55              
Impacted Files Coverage Δ
pool/options.go 100.00% <ø> (+33.33%) ⬆️
ipc/socket/socket_factory.go 77.53% <100.00%> (-1.34%) ⬇️
pool/allocator.go 100.00% <100.00%> (ø)
pool/static_pool.go 66.81% <100.00%> (+3.14%) ⬆️
worker/state.go 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5629950...5ef135f. Read the comment docs.

@rustatian rustatian merged commit c28e477 into master Feb 14, 2022
@bors bors bot deleted the bug/socket_error branch February 14, 2022 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B-bug Bug: bug, exception
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: Socket errors during workers restarting
1 participant