Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stat): job plugin drivers statistic #764

Merged
merged 20 commits into from
Aug 18, 2021
Merged

feat(stat): job plugin drivers statistic #764

merged 20 commits into from
Aug 18, 2021

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Aug 14, 2021

Reason for This PR

closes #760
closes #761

Description of Changes

  • JobsStatus informer interface.
  • New stat package with jobs-related statistics.
  • Go 1.17 by default.
  • Stat RPC call to obtain information about pipelines and drivers.
  • New protobuf messages to handle RPC Stat.
  • Prometheus metrics: number of pushes, number of successfully processed jobs, number of failed jobs, number of failed pushes, workers memory.

Stat sample (WIP):
image

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. A-metrics Area: metrics labels Aug 14, 2021
@rustatian rustatian requested a review from wolfy-j August 14, 2021 17:33
@rustatian rustatian self-assigned this Aug 14, 2021
@rustatian rustatian added this to the 2.4.0 milestone Aug 14, 2021
@rustatian rustatian changed the title feat(stat): job drivers statistic feat(stat): job plugin drivers statistic Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #764 (eb70b89) into master (6860326) will decrease coverage by 0.11%.
The diff coverage is 65.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   66.39%   66.28%   -0.12%     
==========================================
  Files         126      129       +3     
  Lines       10331    10795     +464     
==========================================
+ Hits         6859     7155     +296     
- Misses       2868     3023     +155     
- Partials      604      617      +13     
Impacted Files Coverage Δ
pkg/events/jobs_events.go 0.00% <0.00%> (ø)
pkg/pool/supervisor_pool.go 89.47% <ø> (ø)
pkg/state/process/state.go 36.11% <ø> (ø)
pkg/worker_handler/errors.go 0.00% <ø> (ø)
plugins/gzip/plugin.go 88.88% <ø> (ø)
plugins/http/plugin.go 81.02% <ø> (ø)
plugins/informer/rpc.go 64.00% <0.00%> (-9.92%) ⬇️
plugins/redis/kv/kv.go 58.28% <ø> (ø)
plugins/service/plugin.go 70.31% <ø> (ø)
utils/isolate.go 6.66% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5435be...eb70b89. Read the comment docs.

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
memleak.php for the non-memory tests

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Add Stat with tests

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian marked this pull request as ready for review August 18, 2021 13:30
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit 324407b into master Aug 18, 2021
@bors bors bot deleted the jobs/stat branch August 18, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-metrics Area: metrics C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RR2, JOBS, METRICS] Expose Stats RPC call [RR2, JOBS, METRICS] Expose jobs metrics
1 participant