Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check nil case for the bytes cast #201

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Apr 23, 2024

Reason for This PR

closes: roadrunner-server/roadrunner#1903

Description of Changes

  • Additionally, check for the nil bytes.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of cases where request bodies are empty to prevent errors and enhance application stability.

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added the bug Something isn't working label Apr 23, 2024
@rustatian rustatian requested a review from wolfy-j April 23, 2024 12:46
@rustatian rustatian self-assigned this Apr 23, 2024
Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent modification in the code introduces a safeguard to handle scenarios where the input body (r.body) is null. This adjustment ensures that the function gracefully handles null values, avoiding potential errors in the switch statement and enhancing the overall stability of the application.

Changes

File Change Summary
.../request.go Added a check to return nil if r.body is nil, improving robustness.

Poem

🐇💻
In the land of code, where the rabbits hop,
A tiny change was made, not a lot.
But oh, how it smooths the flow,
Where nulls once troubled, now they go.
Cheers to safe checks, hip hip hooray!
Onward we code, with less dismay. 🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between dc955e5 and 1563bcf.
Files selected for processing (1)
  • handler/request.go (1 hunks)
Additional comments not posted (1)
handler/request.go (1)

189-191: Add a nil check for r.body to prevent processing when it's nil.

This change enhances the robustness of the code by ensuring that the method returns early if r.body is nil, preventing any further processing which could lead to errors.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustatian rustatian merged commit 7511e0d into master Apr 23, 2024
6 checks passed
@rustatian rustatian deleted the fix/npe-bytes-conversion branch April 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: panic in http plugin
1 participant