Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(frame): reduce bound checks #143

Merged
merged 2 commits into from
Aug 4, 2021
Merged

perf(frame): reduce bound checks #143

merged 2 commits into from
Aug 4, 2021

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Aug 3, 2021

Reason for This PR

closes: #125

Description of Changes

  • 50% reduce bound checks. Rewrite most of the frame operations.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s) or (git commit -S).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added this to the 3.1.5 milestone Aug 3, 2021
@rustatian rustatian requested a review from wolfy-j August 3, 2021 18:07
@rustatian rustatian self-assigned this Aug 3, 2021
Signed-off-by: Valery Piashchynski <[email protected]>
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #143 (e7fe0fc) into master (0b1e40f) will increase coverage by 0.13%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   57.01%   57.14%   +0.13%     
==========================================
  Files           9        9              
  Lines         542      539       -3     
==========================================
- Hits          309      308       -1     
+ Misses        201      200       -1     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
pkg/rpc/decoders.go 25.49% <40.00%> (ø)
pkg/rpc/client.go 75.00% <75.00%> (ø)
internal/receive.go 80.95% <100.00%> (ø)
pkg/frame/frame.go 88.50% <100.00%> (+1.83%) ⬆️
pkg/rpc/codec.go 64.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1e40f...e7fe0fc. Read the comment docs.

@rustatian rustatian merged commit d5cf35b into master Aug 4, 2021
@bors bors bot deleted the perf/bce branch August 4, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GORIDGE3] Eliminate BC (bound checks) for the hot paths
2 participants