Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!:use LocationPuck instead of deprecated NativeUserLocation #3497

Merged
merged 2 commits into from
Jun 29, 2024
Merged

refactor!:use LocationPuck instead of deprecated NativeUserLocation #3497

merged 2 commits into from
Jun 29, 2024

Conversation

chuchuva
Copy link
Contributor

@chuchuva chuchuva commented May 23, 2024 •
edited
Loading

Follow-up for #3222

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder

@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
@chuchuva chuchuva temporarily deployed to CI with Mapbox Tokens May 23, 2024 00:08 — with GitHub Actions Inactive
mfazekas
mfazekas approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lurtroxx
Copy link

Is this a fix for the current version failure for EAS build?

[RUN_FASTLANE]
❌ (node_modules/@rnmapbox/maps/ios/RNMBX/RNMBXNativeUserLocation.swift:48:21)

46 | public var visible: Bool = false
47 |

48 | var _puckBearing: PuckBearing? = nil
| ^ cannot find type 'PuckBearing' in scope
49 |
50 | @objc
51 | public var puckBearing: String? {

@chuchuva
Copy link
Contributor Author

Unlikely, it's just refactoring in TypeScript code.

@mfazekas mfazekas merged commit 485dca8 into rnmapbox:main Jun 29, 2024
10 checks passed
@chuchuva chuchuva deleted the patch-3 branch August 6, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfazekas mfazekas mfazekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuchuva @Lurtroxx @mfazekas