fix(android): requestDisallowInterceptTouchEvent broken

[VolkerLieber]

Description

Fixes #3326 by waiting until mMapView has been initialized.

[mfazekas]

Suggested change

	it.requestDisallowInterceptTouchEvent = requestDisallowInterceptTouchEvent.asBoolean()
	it.requestDisallowInterceptTouchEvent = mapView.requestDisallowInterceptTouchEvent

[VolkerLieber]

Would that not just be x = x ?

[mfazekas]

Variable naming is a bit confusing there. ‘it’ is mapbox’s MapView, mapView is RNMBXMapView

[VolkerLieber]

My bad, I have to admit, that I tried to fix this issue while being on the go. I've now correctly set up the development environment and my new commit seems to be the best solution for me.

@ReactProp(name = "requestDisallowInterceptTouchEvent")
override fun setRequestDisallowInterceptTouchEvent(mapView: RNMBXMapView, requestDisallowInterceptTouchEvent: Dynamic) {
    mapView.requestDisallowInterceptTouchEvent = requestDisallowInterceptTouchEvent.asBoolean()
}

Calls

var requestDisallowInterceptTouchEvent: Boolean = false
    set(value) {
        val oldValue = field
        field = value
        updateRequestDisallowInterceptTouchEvent(oldValue, value)
    }

Which calls

fun RNMBXMapView.updateRequestDisallowInterceptTouchEvent(oldValue: Boolean, value: Boolean) {
    if (oldValue == value) {
        return
    }
    if (value) {
        mapView.setOnTouchListener { view, event ->
            this.requestDisallowInterceptTouchEvent(true)
            mapView.onTouchEvent(event)
            true
        }
    } else {
        mapView.setOnTouchListener { view, event ->
            mapView.onTouchEvent(event)
        }
    }
}

The issue arises, because mapView is not initialized then mapView.setOnTouchListener is first called. By wrapping it with withMapView, this should be fixed.

What do you think?

[mfazekas]

Looks good