Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image scaling on android in production #3103

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

mfazekas
Copy link
Contributor

@mfazekas mfazekas commented Oct 12, 2023

Fixes: #3009

So in production our assets looks like this:

{icon1: {"scale":2,"height":64,"uri":"src_assets_scaletesticon","width":64,"__packager_asset":true}}

The issue was solved by using fresco to load images from resource in case of release mode. Previously we've loaded manually and we were using wrong combination of scale, inDensity, inScreenDensity, inTargetDensity. (tested with yarn android --mode release )

image

@mfazekas mfazekas merged commit 4926186 into main Oct 13, 2023
9 checks passed
@mfazekas mfazekas deleted the mfazekas/fix-density-android branch October 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: inconsistent iconSize between iOS and Android
1 participant