Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate whole library to new arch #3048

Closed

Conversation

WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Sep 13, 2023

PR adding New Architecture support to the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


Notes

This PR includes almost all the changes needed for migration to new arch gathered together. It has been split to smaller PRs: #3141, #3136, #3135, #3130, #3123, #3092, #3091, #3090 🚀

@WoLewicki WoLewicki changed the title @wolewicki/new arch atmosphere migrate whole library to new arch Sep 13, 2023
@mfazekas
Copy link
Contributor

@WoLewicki thank much for the effort. I'm a bit concerned about the amount of changes. It will be very hard to review/manage this.

Also please use RNMBX prefix instead of MBX as MBX prefix is already used by some Mapbox components.

@WoLewicki
Copy link
Contributor Author

This PR is just a draft with all the changes I make. We will for sure split it to smaller PRs so it is much easier to test and review. I'll also change the names of components 🚀

@mfazekas
Copy link
Contributor

This PR is just a draft with all the changes I make. We will for sure split it to smaller PRs so it is much easier to test and review. I'll also change the names of components 🚀

Cool that sounds great. One issue is that I'm working on supporting the v11 api. See #3040, not sure what's the best way to make merges easier for both of us.

@WoLewicki
Copy link
Contributor Author

I think we can handle it in each component one-by-one when migrating them.

@mfazekas
Copy link
Contributor

I think we can handle it in each component one-by-one when migrating them.

👍

@WoLewicki
Copy link
Contributor Author

Closing in favor of many other PRs based on this one 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants