Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mglStyleValueColorRaw properly converts color, fixing color prop on Light #3045

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

MichaelDanielTom
Copy link
Contributor

No description provided.

@mfazekas
Copy link
Contributor

@MichaelDanielTom thanks much, looks good, can you post an example that reproduces the issue it fixes?

@MichaelDanielTom
Copy link
Contributor Author

To reproduce, just include Light anywhere in your MapView and set a color.

<Mapbox.MapView>
  <Mapbox.Light style={{ color: 'blue' }} />
</Mapbox.MapView>

Using any value for color in Light's layer style will result in an error like so:

Mapbox error Unexpeted value for color: 4294967295, retuning red {"level": "error", "message": "Unexpeted value for color: 4294967295, retuning red"}

@mfazekas mfazekas merged commit 9fe7ed0 into rnmapbox:main Sep 13, 2023
@MichaelDanielTom MichaelDanielTom deleted the lightColorIosFix branch September 13, 2023 19:03
orca-nazar pushed a commit to orca-io/maps that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants