enable stricter typescript rules #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobber
reviewed
Oct 26, 2022
| "outDir": "lib/javascript", | ||
| "noUnusedLocals": true, | ||
| "noImplicitAny": true, | ||
| "noImplicitReturns": true, |
There was a problem hiding this comment.
FYI, noImplicitReturns is unnecessary when using strict mode. You won't see this error thrown.
Strict mode includes strictNullChecks that supersedes noImplicitReturns.
There was a problem hiding this comment.
Thanks. I've removed noImplicitAny and noImplicitThis as they are part of strict mode.
However, noImplicitReturns is not part of strict mode, so I haven't removed that one.
(I've tested the latter by removing the implicit return fix in AbstractLayer.tsx:55, the code then compiles without noImplicitReturns but breaks (as intended) when noImplicitReturns is enabled
mfazekas
approved these changes
Oct 27, 2022
|
Thanks for the quick merge! @mfazekas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few stricter Typescript rules, so that until #2172 is fixed, this package can still be consumed in apps with strict Typescript settings (#2333).
To fix the
is declared but its value is never readerrors, I have changed MapBoxStyles.ts to a declaration file (.d.ts)Description
Fixes #2333
Checklist
yarn generatein the root folderindex.d.ts)/example)