-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement camera bounds-based animation and easing on iOS with V10 SDK #1833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naftalibeder thanks this looks good to me, thanks much for the patch!
@mfazekas Sorry, I should have clarified - this could probably have been considered a work in progress (missing Android, as well as padding - in fact, I have a small refactor on the iOS side in progress to allow that). I don’t know if you want to revert the merge, or if I should just open a new PR, but reopening this PR might produce a cleaner history. |
@naftalibeder, sorry for that. I think it's already an improvement, feel free to open a new PR. |
No worries! Thanks :) |
@naftalibeder I also has some improvements for v10 iOS side of camera, based on your work at #1835. Hopefully you can merge it with your newer changes. |
Description
Implements camera bounds-based animation and easing using the V10 SDK. Currently implemented only on iOS, and I can port it to Android if there's agreement that this can be merged into
main
.Checklist
yarn lint:fix
in the root folderyarn generate
in the root folderCHANGELOG.md
I updated the typings files ((N/A)index.d.ts
)/example
)Video
example2.mov