Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement camera bounds-based animation and easing on iOS with V10 SDK #1833

Merged
merged 7 commits into from
Apr 14, 2022

Conversation

naftalibeder
Copy link
Collaborator

@naftalibeder naftalibeder commented Apr 12, 2022

Description

Implements camera bounds-based animation and easing using the V10 SDK. Currently implemented only on iOS, and I can port it to Android if there's agreement that this can be merged into main.

Checklist

  • I have tested this on a device/simulator for each compatible OS (iOS only right now)
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts) (N/A)
  • I added/ updated a sample (/example)

Video

example2.mov

@naftalibeder naftalibeder changed the title Feat/map Implement camera bounds-based animation and easing with V10 SDK Apr 12, 2022
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naftalibeder thanks this looks good to me, thanks much for the patch!

@mfazekas mfazekas merged commit 222c13d into rnmapbox:main Apr 14, 2022
@naftalibeder
Copy link
Collaborator Author

@mfazekas Sorry, I should have clarified - this could probably have been considered a work in progress (missing Android, as well as padding - in fact, I have a small refactor on the iOS side in progress to allow that).

I don’t know if you want to revert the merge, or if I should just open a new PR, but reopening this PR might produce a cleaner history.

@mfazekas
Copy link
Contributor

@naftalibeder, sorry for that. I think it's already an improvement, feel free to open a new PR.

@naftalibeder naftalibeder changed the title Implement camera bounds-based animation and easing with V10 SDK Implement camera bounds-based animation and easing on iOS with V10 SDK Apr 14, 2022
@naftalibeder
Copy link
Collaborator Author

No worries! Thanks :)

@mfazekas
Copy link
Contributor

@naftalibeder I also has some improvements for v10 iOS side of camera, based on your work at #1835. Hopefully you can merge it with your newer changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants