feat: new arch fixes (#3141)

* fix: static cast for props * feat: add viewTagResolver to other modules
rnmapbox · Oct 27, 2023 · 6e77c7b · 6e77c7b
1 parent 32d0990
commit 6e77c7b
Show file tree

Hide file tree

Showing 32 changed files with 84 additions and 31 deletions.
diff --git a/android/src/main/java/com/rnmapbox/rnmbx/RNMBXPackage.kt b/android/src/main/java/com/rnmapbox/rnmbx/RNMBXPackage.kt
@@ -90,20 +90,20 @@ class RNMBXPackage : TurboReactPackage() {
 
         // annotations
         managers.add(RNMBXMarkerViewManager(reactApplicationContext))
-        managers.add(RNMBXPointAnnotationManager(reactApplicationContext))
+        managers.add(RNMBXPointAnnotationManager(reactApplicationContext, getViewTagResolver(reactApplicationContext)))
         managers.add(RNMBXCalloutManager())
         managers.add(RNMBXNativeUserLocationManager())
 
         // sources
         managers.add(RNMBXVectorSourceManager(reactApplicationContext))
-        managers.add(RNMBXShapeSourceManager(reactApplicationContext))
+        managers.add(RNMBXShapeSourceManager(reactApplicationContext, getViewTagResolver(reactApplicationContext)))
         managers.add(RNMBXRasterDemSourceManager(reactApplicationContext))
         managers.add(RNMBXRasterSourceManager(reactApplicationContext))
         managers.add(RNMBXImageSourceManager())
 
         // images
         managers.add(RNMBXImagesManager(reactApplicationContext))
-        managers.add(RNMBXImageManager(reactApplicationContext))
+        managers.add(RNMBXImageManager(reactApplicationContext, getViewTagResolver(reactApplicationContext)))
 
         // layers
         managers.add(RNMBXFillLayerManager())

diff --git a/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXPointAnnotation.kt b/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXPointAnnotation.kt
@@ -74,6 +74,11 @@ class RNMBXPointAnnotation(private val mContext: Context, private val mManager:
         mMapView?.offscreenAnnotationViewContainer?.removeView(childView)
     }
 
+    override fun setId(id: Int) {
+        super.setId(id)
+        mManager.tagAssigned(id)
+    }
+
     override fun addToMap(mapView: RNMBXMapView) {
         super.addToMap(mapView)
         mMap = mapView.getMapboxMap()

diff --git a/...oid/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXPointAnnotationManager.kt b/...oid/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXPointAnnotationManager.kt
@@ -9,10 +9,12 @@ import com.facebook.react.uimanager.annotations.ReactProp
 import com.facebook.react.viewmanagers.RNMBXPointAnnotationManagerDelegate
 import com.facebook.react.viewmanagers.RNMBXPointAnnotationManagerInterface
 import com.rnmapbox.rnmbx.components.AbstractEventEmitter
+import com.rnmapbox.rnmbx.components.styles.sources.RNMBXShapeSource
 import com.rnmapbox.rnmbx.events.constants.EventKeys
 import com.rnmapbox.rnmbx.utils.GeoJSONUtils.toPointGeometry
+import com.rnmapbox.rnmbx.utils.ViewTagResolver
 
-class RNMBXPointAnnotationManager(reactApplicationContext: ReactApplicationContext) : AbstractEventEmitter<RNMBXPointAnnotation>(reactApplicationContext),
+class RNMBXPointAnnotationManager(reactApplicationContext: ReactApplicationContext, val viewTagResolver: ViewTagResolver) : AbstractEventEmitter<RNMBXPointAnnotation>(reactApplicationContext),
   RNMBXPointAnnotationManagerInterface<RNMBXPointAnnotation> {
 
     private val mDelegate: ViewManagerDelegate<RNMBXPointAnnotation>
@@ -44,6 +46,17 @@ class RNMBXPointAnnotationManager(reactApplicationContext: ReactApplicationConte
         return RNMBXPointAnnotation(reactContext!!, this)
     }
 
+    override fun onDropViewInstance(view: RNMBXPointAnnotation) {
+        val reactTag = view.id
+
+        viewTagResolver.viewRemoved(reactTag)
+        super.onDropViewInstance(view)
+    }
+
+    fun tagAssigned(reactTag: Int) {
+        return viewTagResolver.tagAssigned(reactTag)
+    }
+
     @ReactProp(name = "id")
     override fun setId(annotation: RNMBXPointAnnotation, id: Dynamic) {
         annotation.iD = id.asString()

diff --git a/android/src/main/java/com/rnmapbox/rnmbx/components/images/RNMBXImage.kt b/android/src/main/java/com/rnmapbox/rnmbx/components/images/RNMBXImage.kt
@@ -28,6 +28,11 @@ class RNMBXImage(private val mContext: ReactApplicationContext, private val mMan
 
     var mBitmap : Bitmap? = null
 
+    override fun setId(id: Int) {
+        super.setId(id)
+        mManager.tagAssigned(id)
+    }
+
     override fun onLayoutChange(v: View, left: Int, top: Int, right: Int, bottom: Int, oldLeft: Int, oldTop: Int,
                                 oldRight: Int, oldBottom: Int) {
         if (left == 0 && top == 0 && right == 0 && bottom == 0) {

diff --git a/android/src/main/java/com/rnmapbox/rnmbx/components/images/RNMBXImageManager.kt b/android/src/main/java/com/rnmapbox/rnmbx/components/images/RNMBXImageManager.kt
@@ -7,8 +7,10 @@ import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.uimanager.annotations.ReactProp
 import com.facebook.react.viewmanagers.RNMBXImageManagerInterface
 import com.rnmapbox.rnmbx.components.AbstractEventEmitter
+import com.rnmapbox.rnmbx.components.styles.sources.RNMBXShapeSource
+import com.rnmapbox.rnmbx.utils.ViewTagResolver
 
-class RNMBXImageManager(private val mContext: ReactApplicationContext) : AbstractEventEmitter<RNMBXImage>(
+class RNMBXImageManager(private val mContext: ReactApplicationContext, val viewTagResolver: ViewTagResolver) : AbstractEventEmitter<RNMBXImage>(
 mContext
 ), RNMBXImageManagerInterface<RNMBXImage> {
     override fun getName(): String {
@@ -23,6 +25,17 @@ mContext
         return mutableMapOf();
     }
 
+    override fun onDropViewInstance(view: RNMBXImage) {
+        val reactTag = view.id
+
+        viewTagResolver.viewRemoved(reactTag)
+        super.onDropViewInstance(view)
+    }
+
+    fun tagAssigned(reactTag: Int) {
+        return viewTagResolver.tagAssigned(reactTag)
+    }
+
     // region React properties
     @ReactProp(name="name")
     override fun setName(image: RNMBXImage, value: Dynamic) {

diff --git a/android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXShapeSource.kt b/android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXShapeSource.kt
@@ -48,6 +48,11 @@ class RNMBXShapeSource(context: Context, private val mManager: RNMBXShapeSourceM
         }
     }
 
+    override fun setId(id: Int) {
+        super.setId(id)
+        mManager.tagAssigned(id)
+    }
+
     override fun makeSource(): GeoJsonSource {
         val builder = GeoJsonSource.Builder(iD.toString())
         getOptions(builder)

diff --git a/...oid/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXShapeSourceManager.kt b/...oid/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXShapeSourceManager.kt
@@ -14,13 +14,14 @@ import com.mapbox.maps.extension.style.expressions.generated.Expression
 import com.rnmapbox.rnmbx.events.constants.EventKeys
 import com.rnmapbox.rnmbx.utils.ExpressionParser
 import com.rnmapbox.rnmbx.utils.Logger
+import com.rnmapbox.rnmbx.utils.ViewTagResolver
 import java.net.MalformedURLException
 import java.net.URL
 import java.util.ArrayList
 import java.util.HashMap
 
 
-class RNMBXShapeSourceManager(private val mContext: ReactApplicationContext) :
+class RNMBXShapeSourceManager(private val mContext: ReactApplicationContext, val viewTagResolver: ViewTagResolver) :
     AbstractEventEmitter<RNMBXShapeSource>(
         mContext
     ), RNMBXShapeSourceManagerInterface<RNMBXShapeSource> {
@@ -48,6 +49,17 @@ class RNMBXShapeSourceManager(private val mContext: ReactApplicationContext) :
         source.removeLayer(childPosition)
     }
 
+    override fun onDropViewInstance(view: RNMBXShapeSource) {
+        val reactTag = view.id
+
+        viewTagResolver.viewRemoved(reactTag)
+        super.onDropViewInstance(view)
+    }
+
+    fun tagAssigned(reactTag: Int) {
+        return viewTagResolver.tagAssigned(reactTag)
+    }
+
     @ReactProp(name = "id")
     override fun setId(source: RNMBXShapeSource, id: Dynamic) {
         source.iD = id.asString()

diff --git a/ios/RNMBX/RNMBXAtmosphereComponentView.mm b/ios/RNMBX/RNMBXAtmosphereComponentView.mm
@@ -50,7 +50,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXAtmosphereProps>(props);
+  const auto &newProps = static_cast<const RNMBXAtmosphereProps &>(*props);
     id reactStyle = RNMBXConvertFollyDynamicToId(newProps.reactStyle);
     if (reactStyle != nil) {
         _view.reactStyle = reactStyle;

diff --git a/ios/RNMBX/RNMBXBackgroundLayerComponentView.mm b/ios/RNMBX/RNMBXBackgroundLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXBackgroundLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXBackgroundLayerProps &>(*props);
   RNMBXSetCommonLayerPropsWithoutSourceID(newProps, _view);
 
 

diff --git a/ios/RNMBX/RNMBXCalloutComponentView.mm b/ios/RNMBX/RNMBXCalloutComponentView.mm
@@ -42,7 +42,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXCalloutProps>(props);
+  const auto &newProps = static_cast<const RNMBXCalloutProps &>(*props);
 
   [super updateProps:props oldProps:oldProps];
 }

diff --git a/ios/RNMBX/RNMBXCameraComponentView.mm b/ios/RNMBX/RNMBXCameraComponentView.mm
@@ -69,7 +69,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXCameraProps>(props);
+  const auto &newProps = static_cast<const RNMBXCameraProps &>(*props);
     id maxBounds = RNMBXConvertFollyDynamicToId(newProps.maxBounds);
     if (maxBounds != nil) {
         _view.maxBounds = maxBounds;

diff --git a/ios/RNMBX/RNMBXCircleLayerComponentView.mm b/ios/RNMBX/RNMBXCircleLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXCircleLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXCircleLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXFillExtrusionLayerComponentView.mm b/ios/RNMBX/RNMBXFillExtrusionLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXFillExtrusionLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXFillExtrusionLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
 

diff --git a/ios/RNMBX/RNMBXFillLayerComponentView.mm b/ios/RNMBX/RNMBXFillLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXFillLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXFillLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXHeatmapLayerComponentView.mm b/ios/RNMBX/RNMBXHeatmapLayerComponentView.mm
@@ -47,7 +47,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXHeatmapLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXHeatmapLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
 

diff --git a/ios/RNMBX/RNMBXImageComponentView.mm b/ios/RNMBX/RNMBXImageComponentView.mm
@@ -65,7 +65,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXImageProps>(props);
+  const auto &newProps = static_cast<const RNMBXImageProps &>(*props);
     id stretchX = RNMBXConvertFollyDynamicToId(newProps.stretchX);
     if (stretchX != nil) {
         _view.stretchX = stretchX;

diff --git a/ios/RNMBX/RNMBXImageSourceComponentView.mm b/ios/RNMBX/RNMBXImageSourceComponentView.mm
@@ -70,7 +70,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXImageSourceProps>(props);
+  const auto &newProps = static_cast<const RNMBXImageSourceProps &>(*props);
     id idx = RNMBXConvertFollyDynamicToId(newProps.id);
     if (idx != nil) {
         _view.id = idx;

diff --git a/ios/RNMBX/RNMBXImagesComponentView.mm b/ios/RNMBX/RNMBXImagesComponentView.mm
@@ -68,7 +68,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXImagesProps>(props);
+  const auto &newProps = static_cast<const RNMBXImagesProps &>(*props);
     id images = RNMBXConvertFollyDynamicToId(newProps.images);
     if (images != nil) {
         _view.images = images;

diff --git a/ios/RNMBX/RNMBXLightComponentView.mm b/ios/RNMBX/RNMBXLightComponentView.mm
@@ -49,7 +49,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXLightProps>(props);
+  const auto &newProps = static_cast<const RNMBXLightProps &>(*props);
     id reactStyle = RNMBXConvertFollyDynamicToId(newProps.reactStyle);
     if (reactStyle != nil) {
         _view.reactStyle = reactStyle;

diff --git a/ios/RNMBX/RNMBXLineLayerComponentView.mm b/ios/RNMBX/RNMBXLineLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXLineLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXLineLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXMapViewComponentView.mm b/ios/RNMBX/RNMBXMapViewComponentView.mm
@@ -125,7 +125,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXMapViewProps>(props);
+  const auto &newProps = static_cast<const RNMBXMapViewProps &>(*props);
     id attributionEnabled = RNMBXConvertFollyDynamicToId(newProps.attributionEnabled);
     if (attributionEnabled != nil) {
         _view.reactAttributionEnabled = attributionEnabled;

diff --git a/ios/RNMBX/RNMBXMarkerViewComponentView.mm b/ios/RNMBX/RNMBXMarkerViewComponentView.mm
@@ -70,7 +70,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXMarkerViewProps>(props);
+  const auto &newProps = static_cast<const RNMBXMarkerViewProps &>(*props);
 
     id coordinate = RNMBXConvertFollyDynamicToId(newProps.coordinate);
     if (coordinate != nil) {

diff --git a/ios/RNMBX/RNMBXNativeUserLocationComponentView.mm b/ios/RNMBX/RNMBXNativeUserLocationComponentView.mm
@@ -53,7 +53,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXNativeUserLocationProps>(props);
+  const auto &newProps = static_cast<const RNMBXNativeUserLocationProps &>(*props);
     id iosShowsUserHeadingIndicator = RNMBXConvertFollyDynamicToId(newProps.iosShowsUserHeadingIndicator);
     if (iosShowsUserHeadingIndicator != nil) {
         _view.iosShowsUserHeadingIndicator = iosShowsUserHeadingIndicator;

diff --git a/ios/RNMBX/RNMBXPointAnnotationComponentView.mm b/ios/RNMBX/RNMBXPointAnnotationComponentView.mm
@@ -116,7 +116,7 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXPointAnnotationProps>(props);
+  const auto &newProps = static_cast<const RNMBXPointAnnotationProps &>(*props);
     id coordinate = RNMBXConvertFollyDynamicToId(newProps.coordinate);
     if (coordinate != nil) {
         _view.coordinate = coordinate;

diff --git a/ios/RNMBX/RNMBXRasterDemSourceComponentView.mm b/ios/RNMBX/RNMBXRasterDemSourceComponentView.mm
@@ -71,7 +71,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXRasterDemSourceProps>(props);
+  const auto &newProps = static_cast<const RNMBXRasterDemSourceProps &>(*props);
     id idx = RNMBXConvertFollyDynamicToId(newProps.id);
     if (idx != nil) {
         _view.id = idx;

diff --git a/ios/RNMBX/RNMBXRasterLayerComponentView.mm b/ios/RNMBX/RNMBXRasterLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXRasterLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXRasterLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXRasterSourceComponentView.mm b/ios/RNMBX/RNMBXRasterSourceComponentView.mm
@@ -71,7 +71,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXRasterSourceProps>(props);    
+  const auto &newProps = static_cast<const RNMBXRasterSourceProps &>(*props);    
     id idx = RNMBXConvertFollyDynamicToId(newProps.id);
     if (idx != nil) {
         _view.id = idx;

diff --git a/ios/RNMBX/RNMBXShapeSourceComponentView.mm b/ios/RNMBX/RNMBXShapeSourceComponentView.mm
@@ -85,7 +85,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXShapeSourceProps>(props);
+  const auto &newProps = static_cast<const RNMBXShapeSourceProps &>(*props);
     id idx = RNMBXConvertFollyDynamicToId(newProps.id);
     if (idx != nil) {
         _view.id = idx;

diff --git a/ios/RNMBX/RNMBXSkyLayerComponentView.mm b/ios/RNMBX/RNMBXSkyLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXSkyLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXSkyLayerProps &>(*props);
   RNMBXSetCommonLayerPropsWithoutSourceID(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXSymbolLayerComponentView.mm b/ios/RNMBX/RNMBXSymbolLayerComponentView.mm
@@ -48,7 +48,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXSymbolLayerProps>(props);
+  const auto &newProps = static_cast<const RNMBXSymbolLayerProps &>(*props);
   RNMBXSetCommonLayerProps(newProps, _view);
 
   [super updateProps:props oldProps:oldProps];

diff --git a/ios/RNMBX/RNMBXTerrainComponentView.mm b/ios/RNMBX/RNMBXTerrainComponentView.mm
@@ -54,7 +54,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXTerrainProps>(props);
+  const auto &newProps = static_cast<const RNMBXTerrainProps &>(*props);
 
     id sourceID = RNMBXConvertFollyDynamicToId(newProps.sourceID);
     if (sourceID != nil) {

diff --git a/ios/RNMBX/RNMBXVectorSourceComponentView.mm b/ios/RNMBX/RNMBXVectorSourceComponentView.mm
@@ -84,7 +84,7 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
 
 - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
 {
-  const auto &newProps = *std::static_pointer_cast<const RNMBXVectorSourceProps>(props);
+  const auto &newProps = static_cast<const RNMBXVectorSourceProps &>(*props);
     id idx = RNMBXConvertFollyDynamicToId(newProps.id);
     if (idx != nil) {
         _view.id = idx;