Make reporter buffer size and period configurable. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMGranger
commented
Feb 23, 2018
zipkin/include/zipkin/tracer.h
Outdated
| uint32_t collector_port); | ||
| ReporterPtr makeHttpReporter( | ||
| const char *collector_host, uint32_t collector_port, | ||
| SteadyClock::duration reporting_period = std::chrono::milliseconds{500}, |
There was a problem hiding this comment.
Are we okay with repeating the defaults here as well as in the Options struct, or do we want to put these somewhere shared?
There was a problem hiding this comment.
👍 Like the idea of putting defaults somewhere shared.
rnburn
reviewed
Feb 23, 2018
zipkin/src/span_buffer.h
Outdated
| * @return returns the number of spans that can be held in currently allocated | ||
| * storage. | ||
| */ | ||
| uint64_t spanCapacity() { return span_buffer_.capacity(); } |
rnburn
reviewed
Feb 23, 2018
zipkin/src/zipkin_reporter_impl.h
Outdated
| explicit ReporterImpl(TransporterPtr &&transporter); | ||
| explicit ReporterImpl(TransporterPtr &&transporter, | ||
| SteadyClock::duration reporting_period, | ||
| size_t max_buffered_spans); |
|
Looks good. I only had a few small suggestions. |
KevinMGranger
force-pushed
the
configurable_buffer
branch
from
938eac6 to
a4e9c0b
Compare
Co-authored-by: Kevin M Granger <[email protected]>
KevinMGranger
force-pushed
the
configurable_buffer
branch
from
a4e9c0b to
f90a2ab
Compare
|
Changes implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of the work from #9.
I'm taking over working on these changes from Mark.