update intervaltree #391
Merged
update intervaltree #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added friend declaration for findClosest into external header - moved findClosest definition out of external header - uses std::move to build tree - commit id from ekg/intervaltree f0c404
…. Also remove add_vec, instead add to df builder class manually, avoids needing templates for each Rcpp vector class
|
I wasn't able to set up ubsan/asan testing due to challenges getting dependencies installed. valgrind however reported no issues so I believe this should be ready to go. Performance is slightly slower with the updated interval tree. |
|
This looks good. I think the small drop in performance is a good trade off for increased maintainability. We should be more explicit about acknowledging the IntervalTree code from ekg, probably in the comments of |
jayhesselberth
requested changes
Oct 5, 2022
Merge branch 'main' into ivl-tree # Conflicts: # NEWS.md
jayhesselberth
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passes tests and checks but want to run through valgrind and ASAN/UBSAN before merging.
closes #349