Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for dplyr 1.0.0 #363

Closed
wants to merge 7 commits into from

Conversation

romainfrancois
Copy link

Please consider these minor changes for making this package work with dplyr 1.0.0

Not all the problems are fixed though, I'm getting:

test_absdist.r:95: error: ensure that absdist is calculated with respect to input tbls issue#108
'!=' only defined for equally-sized data frames
Backtrace:
 1. testthat::expect_true(any(orig[, c(1:5)] != res[, c(1:5)])) tests/testthat/test_absdist.r:95:2
 4. base::Ops.data.frame(orig[, c(1:5)], res[, c(1:5)])

but maybe that can help. We plan to release dplyr 1.0.0 soon.

@kriemo
Copy link
Member

kriemo commented May 4, 2020

Hi Romain, Thanks for the commits. I was mistakenly waiting for a dplyr release candidate to test against prior to updating on cran. We have fixed these issues in #354 and will update valr on cran asap.

@romainfrancois
Copy link
Author

Thanks :-)

kriemo added a commit that referenced this pull request May 4, 2020
@jayhesselberth
Copy link
Member

Thanks! Changes merged into #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants