Fixed SystemStackError

[olhor]

Fix: calling "indirect_rate" method when rates are not defined throws SystemStackError: stack level too deep.

[shailesh-kalamkar]

Thanks, @olhor for working on the solution.

@rmustafin It would be really helpful if you can review this PR as soon as possible. We are about to deploy this on production and don't want to run into this error. ( We are using latest 1.1.3 version)

Thanks in advance.

[shailesh-kalamkar]

@olhor Tried to use the solution provided here and there is a possible issue with the implementation.

Using the gem with Ruby Money gem like this.

Money.from_amount(100, 'USD', russian_central_bank_object).exchange_to('AED').to_f

When the rate is not available then it should throw Money::Bank::UnknownRate exception but it returning a value 0.

[shailesh-kalamkar]

I will try to check what we can do to fix it. Thanks.

[olhor]

@olhor Tried to use the solution provided here and there is a possible issue with the implementation.

Using the gem with Ruby Money gem like this.

Money.from_amount(100, 'USD', russian_central_bank_object).exchange_to('AED').to_f

When the rate is not available then it should throw Money::Bank::UnknownRate exception but it returning a value 0.

This is what I get:

Money.from_amount(100, 'USD', bank).exchange_to('AED').to_f
[WARNING] The default rounding mode will change from `ROUND_HALF_EVEN` to `ROUND_HALF_UP` in the next major release. Set it explicitly using `Money.rounding_mode=` to avoid potential problems.
Money::Bank::UnknownRate: No conversion rate known for 'USD' -> 'AED'

Are there any prerequisites? Should the rates be present?

[shailesh-kalamkar]

@olhor Oh 🤔

Are there any prerequisites? Should the rates be present?

Doing it like this -

bank_object = Money::Bank::RussianCentralBank.new
bank_object.update_rates

Money.from_amount(100, 'USD', bank_object).exchange_to('AED').to_f

[shailesh-kalamkar]

@olhor Can we trim it down to this ?

def indirect_rate(from, to)
  get_rate('RUB', to) / get_rate('RUB', from)
  dividend = original_get_rate('RUB', to)
  divider = original_get_rate('RUB', from)
  
  dividend && divider && dividend.to_f / divider.to_f
end

[olhor]

Line get_rate('RUB', to) / get_rate('RUB', from) will throw an exception if get_rate returns nil.

[shailesh-kalamkar]

@olhor I am sorry. I missed to remove that line -

def indirect_rate(from, to)
  dividend = original_get_rate('RUB', to)
  divider = original_get_rate('RUB', from)
  
  dividend && divider && dividend.to_f / divider.to_f
end

[olhor]

No problem for me.

[shailesh-kalamkar]

@olhor Really appreciate your work and communication to resolve the issue. Thank you.

[shailesh-kalamkar]

@rmustafin Please check.

[arpit1094]

@olhor any chance we can merge this ?

[olhor]

@arpit1094 Don't ask me. I am not a maintainer, I do not have write access.