This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Libraries shouldn't be proguarded on their own #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be proguarded with app
|
Please explain your reasoning. |
|
Sure, because libs usually (I think at most cases) are compiled along with application (and it's proguarded with it), proguard it without said app doesn't make sense - it also causes proguard file to be more compilated - you have to leave public classes/method, keeping serializable methods etc. |
|
That's a really good point. I want to do a bit of testing on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should be proguarded along with app