This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Refactor nativeMergeAndReplacePix. Addresses #132. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed nativeMergeAndReplacePix so that it now deletes the secondary Pix and uses whatever depth is needed, instead of a hardcoded depth of 1.
|
Looks good to me. Nice fix. If you're at all inclined to look at it, the testPixaReplacePix() test is currently commented out because it crashes in the native code. I'm not sure of the details, but it could use some attention. Thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, after being encouraged by the merge of my first pull request, I decided to try and fix an open issue.
I am submitting this PR to fix issue #132. I refactored 'nativeMergeAndReplacePix' so that it now correctly removes the second supplied image from the Pixa and also correctly gets the depth to use from the source Pix, instead of the old hardcoded depth of '1' which would cause the calls to 'pixRasterop' to fail if the source depths were not both 1. (See file 'rop.c' @ line 226 & 227)
This fixes the test for me.
As always, please let me know if there are any issues. Thanks for your time.