Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in input object argument validation #3370

Merged
merged 1 commit into from
Mar 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ def on_argument(node, parent)
context.directive_definition.arguments
when GraphQL::Language::Nodes::InputObject
arg_type = context.argument_definition.type.unwrap
if arg_type.is_a?(GraphQL::InputObjectType)
arguments = arg_type.input_fields
if arg_type.kind.input_object?
arguments = arg_type.arguments
else
# This is some kind of error
nil
Original file line number Diff line number Diff line change
@@ -248,4 +248,36 @@
end
end
end

describe "for input properties" do
class InputVariableSchema < GraphQL::Schema
class Input < GraphQL::Schema::InputObject
argument(:id, String, required: true)
end

class FooMutation < GraphQL::Schema::Mutation
field(:foo, String, null: true)
argument(:input, Input, required: true)

def resolve(input:)
{ foo: input.id }
end
end

class Mutation < GraphQL::Schema::Object
field(:foo_mutation, mutation: FooMutation)
end

mutation(Mutation)
end

it "gives a proper error" do
res1 = InputVariableSchema.execute("mutation($id: String) { fooMutation(input: { id: $id }) { foo } }")
assert_equal ["Nullability mismatch on variable $id and argument id (String / String!)"], res1["errors"].map { |e| e["message"] }

res2 = InputVariableSchema.execute("mutation($id: String!) { fooMutation(input: { id: $id }) { foo } }", variables: { id: "abc" })
refute res2.key?("errors")
assert_equal "abc", res2["data"]["fooMutation"]["foo"]
end
end
end