-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve argument handling with Dataloader #3320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazingly, performance-wise, this shows an improvement over master (~3.7% less memory, ~5% faster). (I ran the benchmarks on master which paralleled the results in #3312.) Here's the new benchmark result: AFTER profile
|
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite argument loading to support dataloader usage, including in analyzers.
Fixes the known caveat about argument loading done in sequence
Fixes #3313
Fixes #3314
TODO:
Remove old coerce_arguments method (and reconsider the architecture of the new one, maybe move it to has_arguments?)Sometimes this is required out side of execution (for example, parsing arguments of Schema directives) so let's keep this "synchronous" APITest and update input_object code, too?That code is all forinterpreter? => false