Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directive definitions to the lexer, parser, and Generation class. #280

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

cjoudrey
Copy link
Contributor

@cjoudrey cjoudrey commented Sep 27, 2016

While working on #273 I accidentally omitted two lines when copying over Facebook's schema-kitchen-sink.graphql:

directive @skip(if: Boolean!) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT
directive @include(if: Boolean!) on FIELD | FRAGMENT_SPREAD | INLINE_FRAGMENT

This PR adds them and adds support for DirectiveDefinition to the lexer, parser, and Generation.

👀 @rmosolgo for review

@cjoudrey cjoudrey changed the title Add parser/generation support for directive definitions Add support for directive definitions to the lexer, parser, and Generation class. Sep 27, 2016
@rmosolgo
Copy link
Owner

Sweet!!

@rmosolgo rmosolgo merged commit df0e026 into rmosolgo:master Sep 29, 2016
@rmosolgo rmosolgo modified the milestone: 0.19.0 Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants