feat(ObjectType) lookup field implementations from interface, too #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # @return [Array<GraphQL::Field>] All fields, including ones inherited from interfaces | ||
| def all_fields | ||
| interface_fields = interfaces.inject({}) do |memo, iface| |
There was a problem hiding this comment.
How about interfaces.reduce({}, :merge) ? 💃
|
I like this! it's going to be super useful 🎉 |
rmosolgo
force-pushed
the
interface-field-lookup
branch
from
6331d86 to
a75c2a0
Compare
rmosolgo
pushed a commit
that referenced
this pull request
Mar 1, 2016
feat(ObjectType) lookup field implementations from interface, too
|
Yay! Looking forward to giving this a spin 😁 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in our earlier conversation, this allows interfaces to be used as mixins.
You can get field implementations from the interface or you can override them in the object type.
One outstanding issue is, can we cache the result of looking up a field? At what level? Some things I want to support, but don't support well yet, are: