-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild dataloader #3312
Merged
Merged
Rebuild dataloader #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The rails master test is still failing, gotta figure that out separately) |
This was referenced Feb 6, 2021
Closed
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was going to be a little fix, but it turned out to be a total rebuild of the dataloader.
Its path tracking was naive and failed in the case described in #3308. Rebuilding it as a general queue worker was fine, but then it didn't play nice with lazy_resolve.
TODO:
run_batches
back torun
?)Fixes #3308
Profiling info: this increases the memory consumption by 6% in the Dataloader case, but reduces memory in the GraphQL-Batch and No Batch case. Curiously, I'm getting reliably faster times for all three cases. Maybe those ivar writes made the difference -- they would have been slower, but less memory intensive 🤷 . I'll take it!
BEFORE profile
AFTER profile