Fix name collision with tar2files command #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two files have the same name but are found in different subdirectories then tar2files will fail. An example of this is found in abseil-cpp where there are multiple headers with the same name, but sometimes in different subdirectories of
/usr/include
.This change tweaks our tarfile handling so as to key our lookup map based on the path minus anything before the expected prefix (this will remove the
bazel-out/...
bits from the paths generated by the tar2files rule. This provides enough context to avoid the name collisions but is still able to deal with the correct path lookup.