Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: adopt bzlmod #75

Closed
wants to merge 24 commits into from
Closed

wip: adopt bzlmod #75

wants to merge 24 commits into from

Conversation

manuelnaranjo
Copy link
Contributor

TBD

I need to revist the list of commits and squash a few most likely

@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/bzlmod branch 8 times, most recently from cfc6595 to 3f51d00 Compare July 15, 2024 15:05
@manuelnaranjo
Copy link
Contributor Author

Ok now this works as expected, I can consume it from our MODULE.bazel with:

# used to convert RPMs into .tar we can use as container layers
bazel_dep(name = "bazeldnf", version = "0.6.0-rc8")
archive_override(
    module_name = "bazeldnf",
    # computed with:
    # wget <url> -O rule.tar.gz
    # INTEGRITY=$(openssl dgst -sha256 -binary rule.tar.gz | openssl base64 -A | sed 's/^/sha256-/')
    integrity = "sha256-3MuxVWW2Biya+LWNfi7GC3qbWCPg2yr/mInOb7w8rHU=",
    strip_prefix = "bazeldnf-v0.6.0-rc8",
    urls = [
        "https://github.com/bookingcom/bazeldnf/releases/download/v0.6.0-rc8/bazeldnf-v0.6.0-rc8.tar.gz",
    ],
    patch_strip = 1,
    patches = [
        "@//bazel:patches/bazeldnf.patch",
    ],
)

Will cleanup the branch so we can merge the initial bzlmod support

@manuelnaranjo
ci: improve setup
19d57b9 
Using a matrix instead of copying the test structure so many times
@manuelnaranjo
prebuilts: reorganize how we consume prebuilts
797543f 
Prebuilts are now handled differently and require a proper release
process, in order to allow forks to also release we need to consume
GITHUB_REPOSITORY while rendering the repo files.
@manuelnaranjo
fix: adapt repo to the new structure
43a4f91 
There were quite a few missing things from my merged code this should
fix it
@manuelnaranjo
bazel: start adopting bzlmod
76ba245 
When building bazeldnf we now use bzlmod as well
@manuelnaranjo
bazel: run gazelle
b39c2f6 
updating build files to match the latest gazelle settings
@manuelnaranjo
bazel: update e2e for bzlmod
99cf2c4 
adding bazel6 bzlmod test
@manuelnaranjo
ci: adding buildifier job
60dccba 
now we have a step to validate buildifier
@manuelnaranjo
bazel: drop bazeldnf_build_dependencies
0d44950 
We no longer need this bzl file with bzlmod and rules_go go.mod support
@manuelnaranjo
bazel: document packages
70bcbbd 
following the suggestions from bazeldnf linter
@manuelnaranjo
bazel: replace arrays with ctx.actions.args
6278b5a 
ctx.actions.args is a more efficient way of dealing with arguments that
get passed into actions
@manuelnaranjo
ci: improve the release process
8350d5c 
heaviliy inspired in https://github.com/aspect-build/bazel-lib which also
provides a few prebuilt golang binaries
@manuelnaranjo
bazel: get version from package
7b68856 
now while archiving we stamp the content
@manuelnaranjo
bazel: platforms for the repo
046db6d 
Make sure platforms are available accross the entire repository and not
only in bazeldnf/private
@manuelnaranjo
bazel: speed up CI
7209d45 
Making sure github keeps bazel cache around
@manuelnaranjo
bazel: fix legacy external API
91fc5c4 
fixing small issue with the legacy external API
@manuelnaranjo
ci: fix release
38c4040 
We have no config for release, no need to pass this flag
@manuelnaranjo
ci: release is a run target
b4a7748 
We need to execute the release target instead of build
@manuelnaranjo
It's totally insane to have multiple versions
21b82ff 
We don't need to support the multiple versions approach suggested
by the templates repo, we're closer to aspect-bazel-lib than to
a wrapper for already available tools
@manuelnaranjo
move to bazel 7
1d092be 
when building the tool it self we can use bazel 7
@manuelnaranjo
bazel: adopt prebuilt protoc
aea24ea 
Stop waisting valuable CI time in protoc building
@manuelnaranjo
ci: adding bazel-7-bzlmod test
6dd3288 
Closing the loop
@manuelnaranjo manuelnaranjo mentioned this pull request Jul 16, 2024
Merged
@rmohr
Copy link
Owner

rmohr commented Oct 7, 2024

Finally there with #77

@rmohr rmohr closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelnaranjo @rmohr