Migrate to Bazel 7 #67
Conversation
Starting to bump to 7.0.0
Now the repo buils with bazel 7.0.0 and no bzlmod yet
Bumping only the needed rules to make the setup work, making sure both bzlmod and non bzlmod still builds and test as expected
| @@ -0,0 +1,24 @@ | |||
| module( | |||
| name = "bazeldnf", | |||
| version = "0.6.0", | |||
There was a problem hiding this comment.
Is this a value which we need to bump for releases to match the release tag?
There was a problem hiding this comment.
Maybe something which we can always set to the tag value in the release script with e.g. buildozer?
There was a problem hiding this comment.
Yes so the version is something that gets bumped with a GitHub release and the Bazel central registry (BCR) provided with GitHub workflows to make releasing of new versions trivial, there's a template rule from which every new rule is forking, I need to look into the details and adopt, once we have those hooks a new release for BCR is just a tag in another public GitHub repo
| go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps") | ||
| go_deps.from_file(go_mod = "//:go.mod") | ||
|
|
||
| use_repo( |
There was a problem hiding this comment.
I think the optimum would be if by default we woulds still just download the recompiled dependencies, so that while we can cleanly pull in the whole go stack, by default we don't have to. Having said that, an initial stab on this which only works with recompile is fine as well.
There was a problem hiding this comment.
Yes so rules_go would become a dev dependency, what other rules are doing is having a public directory in our case it would be bazeldnf and in that directory if someone does bazel build @bazeldnf//bazeldnf/... then the entire path should build.
We would choose to use prebuilt or already built during toolchain registration.
Since I started exploring bzlmod for bazeldnf I also wrote/ported some other rules and learned a lot in the process, I need to close this MR and rebuild based on that, we should make lock file support a chance we introduce once we merge bzlmod.
No worries, sorry for not updating the PR and splitting concerns, now that my rules_rpmbuild work as expected I got my bazeldnf fork to a state that it serves our needs pretty well, I need to go back and split my changes so we can merge |
|
@manuelnaranjo I would love to make bazeldnf fit for bazel 7. Do you think you will have time to separate out the bazel 7 changes? |
|
@rmohr can't promise much, but I'll try |
|
Let's close this one, I'm taking a new hit at this |
Inspired in #61, I'll migrate to bazel 7 while keeping both bzlmod and non bzlmod support working, only updating the minimal amount of packages to not make the MR too convoluted