[REF] abagen.io functions don't copy dataframes by default #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such that if a pandas Dataframe is passed to these function it can optionally (default) be copied and returned or (copy=False) simply returned as-is.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 91.05% 91.03% -0.03%
==========================================
Files 31 31
Lines 1812 1830 +18
==========================================
+ Hits 1650 1666 +16
- Misses 162 164 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default if any of the
abagen.iofunctions were passed a dataframe as input (instead of the expected filepath) it would return a copy of the dataframe. Unfortunately, this is often unwarranted -- there are few instances inabagenwhere a copy of the original dataframe is needed and the original can be used, instead.This PR adds a
copyparameter (False, by default) to all theabagen.iofunctions, and updates a few occasions when those functions are called and copying the input dataframe (if it is, indeed, a dataframe) is needed.