[ENH] Adds option to mirror samples across L/R hemispheres #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we'll be doing a bit more with sample manipulation for L/R hemisphere flipping, etc.
The abagen.get_expression_data() function still referred to a "samples" object that wasn't the module (since we used to hold data in a variable called samples).
Doesn't necessarily DOUBLE the number of samples since samples with mni_x=0 aren't duplicated.
Function had been moved previously and test wasn't updated.
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 90.06% 90.57% +0.51%
==========================================
Files 31 32 +1
Lines 1600 1730 +130
==========================================
+ Hits 1441 1567 +126
- Misses 159 163 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
Adds
abagen.samplesmodule, moving some functionality fromabagen.allenthere, and adds new function (abagen.samples.mirror_samples) that will duplicate all microarray samples across hemispheres. Accessible in the primaryabagen.get_expression_data()workflow via thelr_mirrorboolean parameter.To do:
abagen.samplesmodulelr_mirroroption toabagen.cli