Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adds CLI for abagen.get_expression_data functionality #82

Merged
merged 8 commits into from
Aug 29, 2019

Conversation

rmarkello
Copy link
Owner

@rmarkello rmarkello commented Aug 16, 2019

Closes #70

Adds a command-line interface for the primary workflow available through the abagen.get_expression_data() function so that users don't have to open a Python instance if they're more comfortable with shell scripting.

To do:

  • Add comprehensive tests for CLI
  • Clean up documentation addressing CLI usage

@rmarkello rmarkello force-pushed the enh/cli branch 2 times, most recently from 6f06b44 to 4637c7b Compare August 26, 2019 21:04
In py35 if the path doesn't exist .resolve() throws a FileNotFoundError
(but not in py36 or py37). Add a try/except block to catch the error and
revert back to using os.path if pathlib can't be used.
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #82 into master will decrease coverage by 0.47%.
The diff coverage is 81.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   89.52%   89.05%   -0.48%     
==========================================
  Files          29       31       +2     
  Lines        1470     1562      +92     
==========================================
+ Hits         1316     1391      +75     
- Misses        154      171      +17
Impacted Files Coverage Δ
abagen/tests/test_cli.py 100% <100%> (ø)
abagen/tests/conftest.py 100% <100%> (ø) ⬆️
abagen/cli/run.py 77.33% <77.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bea54b...4f5e5bd. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.53%.
The diff coverage is 96.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   89.52%   90.06%   +0.53%     
==========================================
  Files          29       31       +2     
  Lines        1470     1600     +130     
==========================================
+ Hits         1316     1441     +125     
- Misses        154      159       +5
Impacted Files Coverage Δ
abagen/tests/test_cli.py 100% <100%> (ø)
abagen/tests/conftest.py 100% <100%> (ø) ⬆️
abagen/cli/run.py 93.9% <93.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bea54b...deebe43. Read the comment docs.

Including --save-donors, --save-counts, and --stdout
@rmarkello rmarkello marked this pull request as ready for review August 27, 2019 21:01
@rmarkello
Copy link
Owner Author

The tests can't exactly be described as comprehensive, yet, so I really should work on beefing those up before merging...

@rmarkello rmarkello merged commit e8af9d5 into master Aug 29, 2019
@rmarkello rmarkello deleted the enh/cli branch August 29, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line implementation of get_expression_data()
1 participant