Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README #57

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Updated README #57

merged 4 commits into from
Jun 26, 2019

Conversation

JamesFrierson1
Copy link
Contributor

Added additional reference and license information to the README per #49

For some reason I was unable to hyperlink human.brain-map.org but that just may because I'm new at this! Please let me know what else I can do 👍

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          24       24           
  Lines         960      960           
=======================================
  Hits          931      931           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195293a...81ae5dc. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 26, 2019

Pull Request Test Coverage Report for Build 209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.979%

Totals Coverage Status
Change from base Build 206: 0.0%
Covered Lines: 931
Relevant Lines: 960

💛 - Coveralls

Copy link
Owner

@rmarkello rmarkello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JamesFrierson1 ! Thanks so much for this ! I just made one small suggestion replacing some of the text from my issue to be a bit more clear about the Hawrylycz citation. If you're okay with the changes go ahead and accept them and I'll merge this in!

README.rst Outdated Show resolved Hide resolved
@JamesFrierson1
Copy link
Contributor Author

Sounds great, @rmarkello !

@rmarkello
Copy link
Owner

Hey @JamesFrierson1—I think you just marked the suggestion as resolved rather than committing the changes! You should be able to click the "commit suggestion" button to incorporate it. Once you do that I'll go ahead and merge 😄

Co-Authored-By: Ross Markello <[email protected]>
@rmarkello
Copy link
Owner

Perfect! 🎉 Once the CI passes I'll go ahead and merge.

Thanks so much for your contribution!

@JamesFrierson1
Copy link
Contributor Author

Thanks, @rmarkello ! Appreciate your patience 😄

@rmarkello rmarkello merged commit 88fb3e5 into rmarkello:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants