Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adds abagen.correct for postprocessing #20

Merged
merged 14 commits into from
Sep 21, 2018
Merged

Conversation

rmarkello
Copy link
Owner

@rmarkello rmarkello commented Sep 18, 2018

Adds functions for correcting distance-dependent spatial effect of correlated gene expression arrays (abagen.correct.remove_distance()) and for discard genes that do not have a high differential stability across donors (abagen.correct.keep_stable_genes()).

The latter function required adding the ability to return donor-level expression arrays from abagen.get_expression_data(), so this closes #9.

@rmarkello rmarkello force-pushed the postprocessing branch 2 times, most recently from 074404a to f3c7a6a Compare September 19, 2018 13:20
New function for correcting distance-dependent spatial effects from
correlated gene expression array
Repository owner deleted a comment from coveralls Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
Repository owner deleted a comment from codecov-io Sep 19, 2018
@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #20 into master will increase coverage by 0.17%.
The diff coverage is 98.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   97.59%   97.76%   +0.17%     
==========================================
  Files          12       14       +2     
  Lines         498      581      +83     
==========================================
+ Hits          486      568      +82     
- Misses         12       13       +1
Impacted Files Coverage Δ
abagen/process.py 100% <ø> (ø) ⬆️
abagen/info.py 100% <ø> (ø) ⬆️
abagen/allen.py 99.03% <100%> (ø) ⬆️
abagen/tests/test_correct.py 100% <100%> (ø)
abagen/correct.py 98.18% <98.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29abbf...8a97a35. Read the comment docs.

Adds function `gene_stability()` in `abagen.correct` for removing genes
that have a differential stability below a given threshold across
donors.
Adds `return_donors` argument to `get_expression_data`, which will
return a list of expression dataframes rather than a single unit. Useful
if users want to post-process the data to select genes with, e.g., high
differential stability.
The `remove_distance()` function in `abagen.correct` previously
considered cortical-subcortical and subcortical-cortical connections
separately when regressing distance, despite an inability to appreciate
directed connections. This patch ensures that distance is regressed from
all cortical-subcortical connections regardless of directionality at the
same time.
@rmarkello rmarkello merged commit 3a276cb into master Sep 21, 2018
@rmarkello rmarkello deleted the postprocessing branch September 21, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for returning donor-level expression arrays
2 participants