[FIX] Fixes logger error w/reports #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned reports were true but because we were calling images.coerce_atlas_to_dict() multiple times the logger was being called multiple times to report what type of atlas was provided.
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 95.09% 95.10%
=======================================
Files 41 41
Lines 3264 3270 +6
=======================================
+ Hits 3104 3110 +6
Misses 160 160
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
abagen.get_expression_data()withreturn_report=Trueandverbose=Truethere was an error in the log. The returned reports were accurate (phew), but because we were callingimages.coerce_atlas_to_dict()multiple times the logger was being called multiple times and therefore reporting (inconsistently) what type of atlas was being used (MNI vs donor-specific). This clears that up.